Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Virtualization #12719

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Mesh Virtualization #12719

merged 2 commits into from
Sep 19, 2024

Conversation

cfjchu
Copy link
Collaborator

@cfjchu cfjchu commented Sep 16, 2024 •
edited
Loading

Ticket

#10419, #10608, #12479

Problem description

  • This PR holistically fixes a number of issues present in the above tickets. The main problem it solves is trying to create a coherent view of what it means to work with multiple devices using MeshDevice.
  • Currently how devices in a mesh are opened differs across supported systems (N300, T3000, TG, TGG). It's also not robust to changes in the physical device-id assignment in the mesh.

What's changed

  • Introduce a SystemMesh abstraction layer which creates a logical 2D mesh virtualization over physically connected devices. The purpose is to create an abstract representation of the system topology so users of MeshDevice can be transparent to physical device ids, ethernet coordinates.
  • This now significantly simplifies and commonizes our T3000/TG MeshDevice Initialization.
  • This work helps unlock:
    • Migrating all T3000 tests over to Galaxy,
    • stamping multiple MeshDevices(2x4) onto SystemMesh,
    • MeshOp/MeshProgram Infra work
    • CCL Operations with Line topology on T3000 MeshDevice

image

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@cfjchu cfjchu changed the title Jchu/device virtualization Device Virtualization into Logical SystemMesh Sep 16, 2024
@cfjchu cfjchu marked this pull request as ready for review September 16, 2024 22:00
@cfjchu cfjchu force-pushed the jchu/device-virtualization branch 2 times, most recently from 8a4b3c5 to c32bc74 Compare September 19, 2024 07:41
@cfjchu
#10608: add method to fetch ethernet coordinates from cluster
78a5f8f
@cfjchu
#10608: add device virtualization btw MeshDevice and physical system
5277994 
- This fixes #10608, #10419 by adding a logical 2D mesh to remap the
physical mesh onto a flattened 2d grid.
- A logical to physical coordinate translation map is now supplied
per supported system.
@cfjchu cfjchu merged commit 7738225 into main Sep 19, 2024
6 checks passed
@cfjchu cfjchu deleted the jchu/device-virtualization branch September 19, 2024 08:13
tt-aho added a commit that referenced this pull request Sep 21, 2024
@tt-aho
Revert "Mesh Virtualization (#12719)"
b85d9e6 
This reverts commit 7738225.
@Aswinmcw Aswinmcw mentioned this pull request Sep 23, 2024
Closed
tt-aho added a commit that referenced this pull request Sep 23, 2024
@tt-aho
Revert "Mesh Virtualization (#12719)"
742a37d 
This reverts commit 7738225.
tt-aho pushed a commit that referenced this pull request Sep 24, 2024
@cfjchu @tt-aho
Mesh Virtualization (#12719)
0a9a627 
* #10608: add method to fetch ethernet coordinates from cluster

* #10608: add device virtualization btw MeshDevice and physical system

- This fixes #10608, #10419 by adding a logical 2D mesh to remap the
physical mesh onto a flattened 2d grid.
- A logical to physical coordinate translation map is now supplied
per supported system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caixunshiren caixunshiren caixunshiren approved these changes

@tt-rkim tt-rkim tt-rkim approved these changes

@cglagovichTT cglagovichTT cglagovichTT approved these changes

@aliuTT aliuTT aliuTT approved these changes

@ttmchiou ttmchiou ttmchiou approved these changes

@jdesousa-TT jdesousa-TT jdesousa-TT approved these changes

@dmakoviichuk-tt dmakoviichuk-tt dmakoviichuk-tt approved these changes

@uaydonat uaydonat Awaiting requested review from uaydonat uaydonat is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin xanderchin is a code owner

@sjameelTT sjameelTT Awaiting requested review from sjameelTT sjameelTT is a code owner

@eyonland eyonland Awaiting requested review from eyonland

@patrickroberts patrickroberts Awaiting requested review from patrickroberts

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

@davorchap davorchap Awaiting requested review from davorchap davorchap is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cfjchu @caixunshiren @tt-rkim @cglagovichTT @aliuTT @ttmchiou @jdesousa-TT @dmakoviichuk-tt