Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Use absolute addressing in startup #12723

Merged
merged 1 commit into from
Sep 17, 2024
Merged

#0: Use absolute addressing in startup #12723

merged 1 commit into from
Sep 17, 2024

Conversation

nathan-TT
Copy link
Contributor

Ticket

NA

Problem description

More execute-in-place investigation. The la assembler macro gets expanded to an auipc/addi pc-relative pair. We do not want pc-relative addressing of non-text segment symbols

What's changed

Use explicit lui/addi pairs. These will be relaxed by the linker to a gp-relative addi reg,gp,$N instruction, where possible.

Checklist

  • [ YES] Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Copy link
Contributor

@pgkeller pgkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nathan-TT nathan-TT merged commit 9a1fa41 into main Sep 17, 2024
6 checks passed
@nathan-TT nathan-TT deleted the nsidwell/abs branch September 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants