Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix start pos in get_rot_mat #12728

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix start pos in get_rot_mat #12728

merged 1 commit into from
Sep 16, 2024

Conversation

kpaigwar
Copy link
Contributor

@kpaigwar kpaigwar commented Sep 16, 2024 •
edited
Loading

Summary

  1. Fixes start pos in get_rotation_mat affecting TG unit tests and demo.
  2. Removed previous fix which only patch full_model test

Checklist

@kpaigwar kpaigwar merged commit d9db9f6 into main Sep 16, 2024
6 checks passed
@kpaigwar kpaigwar deleted the llama3/fix-tg-frequent branch September 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caixunshiren caixunshiren caixunshiren approved these changes

@cglagovichTT cglagovichTT Awaiting requested review from cglagovichTT cglagovichTT is a code owner

@uaydonat uaydonat Awaiting requested review from uaydonat uaydonat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpaigwar @caixunshiren