#12782: Change all sweep framework infra to use loguru #12784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesousa-TT
force-pushed
the
jdesousa/sweeps-logging
branch
4 times, most recently
from
18313fc
to
cca8c00
Compare
xanderchin
approved these changes
Sep 20, 2024
xanderchin
reviewed
Sep 20, 2024
tests/sweep_framework/logger.py
Outdated
There was a problem hiding this comment.
can we rename to sweeps_logger.py ?
jdesousa-TT
force-pushed
the
jdesousa/sweeps-logging
branch
2 times, most recently
from
54ec764
to
c2d6848
Compare
jdesousa-TT
force-pushed
the
jdesousa/sweeps-logging
branch
from
c2d6848
to
f0efb56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12782
Problem description
See issue.
What's changed
Create custom loguru format for sweeps, and use this logger to replace all general prints in the sweep framework.
Checklist