Fix issue w/ CBs getting allocated on ETH cores #12792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgkeller
requested review from
abhullar-tt,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
abhullar-tt
approved these changes
Sep 17, 2024
pgkeller
force-pushed
the
pkeller/bug-12738
branch
from
ceba9da
to
904e760
Compare
abhullar-tt
reviewed
Sep 17, 2024
| tt::tt_metal::detail::ReadFromDeviceL1( | ||
| device, core_coord, program.get_sem_base_addr(device, core_coord, CoreType::WORKER), cb_config_buffer_size, cb_config_vector); | ||
|
|
||
| for (const auto &[buffer_index, golden_cb_config] : cb_config_per_buffer_index) { | ||
| auto base_index = UINT32_WORDS_PER_CIRCULAR_BUFFER_CONFIG * buffer_index; | ||
| fprintf(stderr, "testing %d\n", buffer_index); |
pgkeller
force-pushed
the
pkeller/bug-12738
branch
from
904e760
to
82c09b4
Compare
Were too specific, they are (or will be) broader than just the memmap
pgkeller
force-pushed
the
pkeller/bug-12738
branch
from
82c09b4
to
cba987d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12738
Problem description
Program kernel config init wasn't considering the core type when assigning CBs so CBs on worker cores w/ logical coordinates that overlapped eth cores would get assigned to both tensix and eth
What's changed
Updated the HAL to contain a flag which specifies if the core type supports CBs, this disables CBs on eth cores (not supported). Fixed a couple minor related issues with calculating the size of the CB config
Checklist