Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12529: Add check for in0_mcast_num_cores=1 for noc_async_write_multicast_loopback_src #12796

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

TT-BrianLiu
Copy link
Contributor

@TT-BrianLiu TT-BrianLiu commented Sep 17, 2024

Ticket

Link to Github Issue

Problem description

After some recent changes to multicasting in one of the sharded in0 reader kernels, some edge cases (when N=32) are hanging/bad pcc.

What's changed

It seems like noc_async_write_multicast_loopback_src with linking no longer supports the case where we are just doing a local copy from one CB to another. So the fix is to just use noc_async_write for local copying.

  • Reverts logic update in 59f969
  • Use noc_async_write for local copying between CBs

Checklist

…cast_loopback_src

- Reverts logic update in 59f969
- Use noc_async_write for local copying between CBs
# 0: Set link and reserve bools to true for noc_async_write_multicast calls in in0 block sharded reader kernel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants