-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12529: Add check for in0_mcast_num_cores=1 for noc_async_write_multicast_loopback_src #12796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbradelTT
approved these changes
Sep 18, 2024
TT-BrianLiu
force-pushed
the
jedi
branch
2 times, most recently
from
September 18, 2024 18:59
4973218
to
1bd36c4
Compare
…cast_loopback_src - Reverts logic update in 59f969 - Use noc_async_write for local copying between CBs # 0: Set link and reserve bools to true for noc_async_write_multicast calls in in0 block sharded reader kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
After some recent changes to multicasting in one of the sharded in0 reader kernels, some edge cases (when N=32) are hanging/bad pcc.
What's changed
It seems like
noc_async_write_multicast_loopback_src
with linking no longer supports the case where we are just doing a local copy from one CB to another. So the fix is to just usenoc_async_write
for local copying.Checklist