#12729: add row-major split for BERT #12804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaykru-tt
requested review from
ntarafdar,
sjameelTT and
yan-zaretskiy
as code owners
|
If @sjameelTT's recent changes to slice make it in first, I'll need to update some of the slice calls here to use end-exclusive indexing. |
tests/tt_eager/python_api_testing/unit_testing/misc/test_split_any_dim_rm.py
Show resolved
Hide resolved
sjameelTT
reviewed
Sep 18, 2024
tests/tt_eager/python_api_testing/unit_testing/misc/test_split_any_dim_rm.py
Outdated
Show resolved
Hide resolved
|
hey @jaykru-tt , I'm a little confused with the description. I'm asking because I thought for Bert split we were going to use Tile layout but your description alludes to Bert requiring RM layout. |
ntarafdar
reviewed
Sep 18, 2024
tests/tt_eager/python_api_testing/unit_testing/misc/test_split_any_dim_rm.py
Show resolved
Hide resolved
ntarafdar
approved these changes
Sep 18, 2024
|
post-commit passed, lfg, merging this |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12729
Problem description
The split operation didn't support row major tensors or even the shape [1,256,2] required by BERT when in tiled format.
What's changed
This commit introduces a row major support for the split operation, additionally allowing for n-way splits on any dimension and splits on tensors of rank != 4. I've also added a few test cases, but these only cover 2-way splits on shapes similar to the shape required by BERT.
Checklist