Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12795: Move numpy functions.hpp #12817

Merged
merged 6 commits into from
Sep 22, 2024
Merged

#12795: Move numpy functions.hpp #12817

merged 6 commits into from
Sep 22, 2024

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Sep 18, 2024 •
edited
Loading

Issue : #12795

Work Done:

  • Moved ttnn/cpp/ttnn/deprecated/tt_numpy/functions.hpp --> ttnn/cpp/ttnn/operations/numpy/functions.hpp
  • Changed the namespace from tt::numpy --> ttnn::numpy

CI : All post-commit tests : PASSED

@VirdhatchaniKN VirdhatchaniKN linked an issue Sep 18, 2024 that may be closed by this pull request
Move numpy functions.hpp #12795
Closed
KalaivaniMCW
KalaivaniMCW approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@VirdhatchaniKN VirdhatchaniKN marked this pull request as ready for review September 18, 2024 14:41
VirdhatchaniKN added a commit that referenced this pull request Sep 20, 2024
@VirdhatchaniKN
#12817: Update
c22319c
VirdhatchaniKN added a commit that referenced this pull request Sep 22, 2024
@VirdhatchaniKN
#12817: Update
ca6645e
@VirdhatchaniKN
Copy link
Contributor Author

https://github.com/tenstorrent/tt-metal/actions/runs/10979970283 - passed

@VirdhatchaniKN VirdhatchaniKN merged commit 62aeb39 into main Sep 22, 2024
105 checks passed
@VirdhatchaniKN VirdhatchaniKN deleted the virdhatchani/numpy_functions branch September 22, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mywoodstock mywoodstock mywoodstock approved these changes

@eyonland eyonland eyonland approved these changes

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@KalaivaniMCW KalaivaniMCW KalaivaniMCW approved these changes

@sjameelTT sjameelTT sjameelTT approved these changes

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@umadevimcw umadevimcw Awaiting requested review from umadevimcw

@patrickroberts patrickroberts Awaiting requested review from patrickroberts patrickroberts is a code owner

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy yan-zaretskiy is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@SeanNijjar SeanNijjar Awaiting requested review from SeanNijjar SeanNijjar is a code owner

@ntarafdar ntarafdar Awaiting requested review from ntarafdar ntarafdar is a code owner

@jaykru-tt jaykru-tt Awaiting requested review from jaykru-tt jaykru-tt is a code owner

@shwetankTT shwetankTT Awaiting requested review from shwetankTT shwetankTT is a code owner

@sankarmanoj-tt sankarmanoj-tt Awaiting requested review from sankarmanoj-tt sankarmanoj-tt is a code owner

@pavlejosipovic pavlejosipovic Awaiting requested review from pavlejosipovic pavlejosipovic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move numpy functions.hpp
7 participants
@VirdhatchaniKN @mywoodstock @eyonland @TT-BrianLiu @KalaivaniMCW @sjameelTT @ayerofieiev-tt