Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9370: Workaround: replace WRCFG with RMWCIB instructions in reduce_revert_delta #12832

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

amahmudTT
Copy link
Contributor

@amahmudTT amahmudTT commented Sep 18, 2024

9370

Link to Github Issue

Problem description

The Unpacker uses stale value for address for SrcB even though it is written. It seems to be colliding with WRCFG instructions used in the reduce_revert_delta function. We kept the timing the same and replaced WRCFG instructions with RMWCIB instructions to do the bare minimum and the problem goes away.

What's changed

The workaround uses RMWCIB instructions in the reduce_revert_delta function for wh_b0. It does not have the same timing and consumes more cycles but is functionally the same as what was in the original function.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@amahmudTT amahmudTT force-pushed the amahmud/sdpa_bug_workaround branch 2 times, most recently from 8fa9c64 to a854527 Compare September 18, 2024 19:35
@amahmudTT amahmudTT self-assigned this Sep 18, 2024
@amahmudTT amahmudTT merged commit 44ee68a into main Sep 18, 2024
6 checks passed
@amahmudTT amahmudTT deleted the amahmud/sdpa_bug_workaround branch September 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants