Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12867: Cleanup 9 Unary Backward ops #12920

Merged
merged 4 commits into from
Sep 22, 2024
Merged

#12867: Cleanup 9 Unary Backward ops #12920

merged 4 commits into from
Sep 22, 2024

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Sep 20, 2024 •
edited
Loading

Issue : #12867

Work Done :

  • Cleanup the following structs
    • ExecuteUnaryBackwardFloatWithDefault
    • ExecuteUnaryBackwardShape
    • ExecuteUnaryBackwardTanh
    • ExecuteUnaryBackwardFloatStringDefault
  • Update test file to check for default value cases
  • Update golden function for ops with default values

Test Files :

  • hardshrink_bw : tests/ttnn/unit_tests/operations/backward/test_backward_hardshrink.py - PASSED
  • softshrink_bw : tests/ttnn/unit_tests/operations/backward/test_backward_softshrink.py - PASSED
  • leaky_relu_bw : tests/ttnn/unit_tests/operations/backward/test_backward_leaky_relu.py - PASSED
  • elu_bw : tests/ttnn/unit_tests/operations/backward/test_backward_elu.py - PASSED
  • celu_bw : tests/ttnn/unit_tests/operations/backward/test_backward_celu.py - PASSED
  • logiteps_bw : tests/ttnn/unit_tests/operations/backward/test_backward_logiteps.py - PASSED
  • repeat_bw : tests/ttnn/unit_tests/operations/backward/test_backward_repeat.py - PASSED
  • rdiv_bw : tests/ttnn/unit_tests/operations/backward/test_backward_rdiv.py - PASSED
  • div_no_nan_bw : tests/ttnn/unit_tests/operations/backward/test_backward_div_no_nan.py - PASSED

CI : PASSED

VirdhatchaniKN added a commit that referenced this pull request Sep 20, 2024
@VirdhatchaniKN
#12920: Update test files and golden function to check default value
9acb137
VirdhatchaniKN added a commit that referenced this pull request Sep 20, 2024
@VirdhatchaniKN
#12920: Update test files and golden function to check default value
1cdcbc4
@VirdhatchaniKN VirdhatchaniKN linked an issue Sep 20, 2024 that may be closed by this pull request
Cleanup 9 Unary backward ops #12867
Closed
4 tasks
VirdhatchaniKN added a commit that referenced this pull request Sep 20, 2024
@VirdhatchaniKN
#12920: Update test files and golden function to check default value
505a7f8
Base automatically changed from virdhatchani/3_clean to main September 20, 2024 08:08
VirdhatchaniKN added a commit that referenced this pull request Sep 20, 2024
@VirdhatchaniKN
#12920: Update test files and golden function to check default value
f4deb67
VirdhatchaniKN added a commit that referenced this pull request Sep 20, 2024
@VirdhatchaniKN
#12920: Update test files and golden function to check default value
49fa4b0
Aswinmcw
Aswinmcw approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VirdhatchaniKN
Copy link
Contributor Author

https://github.com/tenstorrent/tt-metal/actions/runs/10979295482 - passed

@VirdhatchaniKN VirdhatchaniKN merged commit 31032c7 into main Sep 22, 2024
105 checks passed
@VirdhatchaniKN VirdhatchaniKN deleted the virdhatchani/4_clean branch September 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcw-anasuya mcw-anasuya mcw-anasuya approved these changes

@Aswinmcw Aswinmcw Aswinmcw approved these changes

@bharane-ab bharane-ab bharane-ab approved these changes

@eyonland eyonland eyonland approved these changes

@patrickroberts patrickroberts Awaiting requested review from patrickroberts patrickroberts is a code owner

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy yan-zaretskiy is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@umadevimcw umadevimcw Awaiting requested review from umadevimcw

@KalaivaniMCW KalaivaniMCW Awaiting requested review from KalaivaniMCW

@ruthreshx ruthreshx Awaiting requested review from ruthreshx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup 9 Unary backward ops
5 participants
@VirdhatchaniKN @eyonland @bharane-ab @Aswinmcw @mcw-anasuya