Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix squeeze Dim == 0 with padding #12940

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix squeeze Dim == 0 with padding #12940

merged 1 commit into from
Sep 20, 2024

Conversation

ntarafdar
Copy link
Contributor

@ntarafdar ntarafdar commented Sep 20, 2024 •
edited by ayerofieiev-tt
Loading

Ticket

Link to Github Issue

Problem description

Regressed on this. Was handled in python before and that handling was removed. Now doing the same stuff in C++.

What's changed

Handling dim == 0 to take into consideration padding in squeeze

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@ntarafdar ntarafdar force-pushed the tarafdarTT/unsqueeze_dim_0 branch 4 times, most recently from 1d331d1 to a6073d0 Compare September 20, 2024 18:50
@ntarafdar ntarafdar marked this pull request as ready for review September 20, 2024 18:50
TT-BrianLiu
TT-BrianLiu approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@TT-BrianLiu TT-BrianLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

ttnn/cpp/ttnn/operations/data_movement/squeeze/squeeze.cpp Outdated Show resolved Hide resolved
@ntarafdar ntarafdar merged commit 613505d into main Sep 20, 2024
6 checks passed
@ntarafdar ntarafdar deleted the tarafdarTT/unsqueeze_dim_0 branch September 20, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@jaykru-tt jaykru-tt jaykru-tt approved these changes

@sjameelTT sjameelTT sjameelTT approved these changes

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@eyonland eyonland Awaiting requested review from eyonland

@patrickroberts patrickroberts Awaiting requested review from patrickroberts

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ntarafdar @TT-BrianLiu @sjameelTT @ayerofieiev-tt @jaykru-tt