#0: Bugfix for launch message setting on watcher hang for Tensix #12956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-dma
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-asaigal and
ubcheema
as code owners
pgkeller
approved these changes
Sep 20, 2024
tt-dma
force-pushed
the
dma/erisc_exit_fix
branch
from
6b70db0
to
c78033c
Compare
On active erisc, when we exit to base FW due to a watcher assert, we need to set the launch message to DONE. This is because the next run will look at the launch message and try to force exit a running kernel if it finds one via launch message GO. The launch message was being set to DONE for Tensix as well, causing SD to finish before picking up the assert.
tt-dma
force-pushed
the
dma/erisc_exit_fix
branch
from
c78033c
to
b9f895f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On active erisc, when we exit to base FW due to a watcher assert, we need to set the launch message to DONE. This is because the next run will look at the launch message and try to force exit a running kernel if it finds one via launch message GO. The launch message was being set to DONE for Tensix as well, causing SD to finish before picking up the assert.
CI running here: https://github.com/tenstorrent/tt-metal/actions/runs/10966525482