#5174: Uplifitng microbenchmarks to run on BH #14191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhullar-tt
requested review from
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema and
tt-rkim
as code owners
tt-aho
reviewed
Oct 24, 2024
tests/tt_metal/tt_metal/perf_microbenchmark/8_dram_adjacent_core_read/test_dram_read.cpp
Outdated
Show resolved
Hide resolved
tt-rkim
approved these changes
Oct 24, 2024
abhullar-tt
force-pushed
the
abhullar/bh-bench
branch
from
d33335d
to
6f9df1e
Compare
yugaoTT
approved these changes
Nov 15, 2024
| uint32_t full_grid_size_y = 12; | ||
|
|
||
| uint32_t full_grid_size_x = device->grid_size().x; | ||
| uint32_t full_grid_size_y = device->grid_size().y; |
There was a problem hiding this comment.
does this return 12 for whb0?
There was a problem hiding this comment.
yes, it pulls the grid size from the soc descriptor yamls
tt-aho
approved these changes
Nov 15, 2024
ubcheema
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#5174
Problem description
Need to uplift these microbenchmark tests to run on BH
Checklist