Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13127: Add physical_shard_shape to ShardSpec attributes #15185

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

TT-BrianLiu
Copy link
Contributor

@TT-BrianLiu TT-BrianLiu commented Nov 18, 2024

Ticket

Link to Github Issue

Problem description

Need to add physical_shard_shape to ShardSpec attributes. Also, ttnn/cpp/pybind11/pytensor.cpp is horribly formatted, so clang formatting it to make it easier to read.

What's changed

  • Update ShardSpec serialization to handle logical and physical sharding
  • Add more ShardSpec serialization c++ tests
  • Clang-format ttnn/cpp/pybind11/pytensor.cpp

Checklist

- Update ShardSpec serialization to handle logical and physical sharding
- Add more ShardSpec serialization c++ tests
@TT-BrianLiu TT-BrianLiu merged commit 1e25da9 into main Nov 19, 2024
9 checks passed
@TT-BrianLiu TT-BrianLiu deleted the bliu/main branch November 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants