Yugao/fix moreh microbenchmark #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase to latest main. |
yugaoTT
force-pushed
the
yugao/fix-moreh-microbenchmark
branch
from
8427b57
to
3590105
Compare
tt-rkim
reviewed
Oct 17, 2023
| pytest $TT_METAL_HOME/tests/scripts/test_moreh_microbenchmark.py::test_noc -k $ARCH_NAME | ||
| pytest $TT_METAL_HOME/tests/scripts/test_moreh_microbenchmark.py::test_matmul_dram -k $ARCH_NAME | ||
| pytest $TT_METAL_HOME/tests/scripts/test_moreh_microbenchmark.py::test_matmul_l1 -k $ARCH_NAME | ||
| for ((i = 0; i < 1; i++)); do |
There was a problem hiding this comment.
1 for loop? Should we just get rid of this?
There was a problem hiding this comment.
yeah I'll delete that
TT-billteng
reviewed
Oct 17, 2023
| @@ -266,7 +266,10 @@ def test_pcie_h2d_l1(iteration, test_vector): | |||
| header = ['Transfer Size', 'WriteToDeviceL1', 'WriteToBuffer', 'EnqueueWriteBuffer'] | |||
| data = [] | |||
| for test_point in test_vector: | |||
| bw_wdd = test_write_device_l1(iteration, 1, test_point) | |||
| if test_point < 1048576: | |||
There was a problem hiding this comment.
is there a better way than using a hard-coded number?
There was a problem hiding this comment.
yeah, the test vector should be smaller than L1 size, I think I should pass it in as pytest parameter?
yugaoTT
force-pushed
the
yugao/fix-moreh-microbenchmark
branch
from
49159df
to
f1bc5fd
Compare
yugaoTT
added a commit
that referenced
this pull request
Oct 17, 2023
yugaoTT
added a commit
that referenced
this pull request
Oct 17, 2023
|
@TT-billteng I told @yugaoTT he can merge in because he addressed my comment, but I didn't notice your comment. Normally, all conversations should be resolved before merging per our contributing standards. Yu showed me his passing u benchmarks pipeline, so I hope it's not a huge problem this time. sorry about that Bill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the device hang problem