Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9208: Functional SqueezeBERT model Demo #9371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#9208: Functional SqueezeBERT model Demo #9371

wants to merge 1 commit into from
+1,452 −0

Conversation

kkeerthana0573
Copy link
Contributor

@kkeerthana0573 kkeerthana0573 commented Jun 11, 2024 •
edited
Loading

Ticket

Problem description

  • Functional SqueezeBERT model Demo.

What's changed

  • TTNN support for SqueezeBERT model.
  • Added demo for SqueezeBertForQuestionAnswering task.

Checklist

  • Post commit CI passes
  • Model regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from b3f15cf to 6f6a917 Compare June 12, 2024 10:59
@kkeerthana0573
Copy link
Contributor Author

Passing CI links:

All post-commit tests
(Single-card) Demo tests
Nightly fast dispatch tests
(Single-card) Device perf regressions
(Single-card) Model perf tests

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch 3 times, most recently from 1aa8267 to 4ca4771 Compare November 11, 2024 06:35
@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from 4ca4771 to 28a2daf Compare November 13, 2024 14:30
@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 18, 2024

Did those device perf checks actually happen?

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from 28a2daf to 28dcc46 Compare November 19, 2024 09:07
@kkeerthana0573
Copy link
Contributor Author

@tt-rkim,
Yes, the device performance checks did happen for the model. Here is the link for the model passing in CI: link

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 19, 2024

2024-11-19 11:56:14.853 | ERROR | models.perf.device_perf_utils:check_device_perf:67 - AVG DEVICE KERNEL SAMPLES/S 186.23090621076346 is outside of expected range (198.559, 210.84099999999998)

eyonland
eyonland approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all your tests pass before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt-rkim tt-rkim tt-rkim left review comments

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@eyonland eyonland eyonland approved these changes

@arakhmati arakhmati Awaiting requested review from arakhmati

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@Sudharsan-V Sudharsan-V Awaiting requested review from Sudharsan-V

@saichandax saichandax Awaiting requested review from saichandax

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@patrickroberts patrickroberts Awaiting requested review from patrickroberts

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@rfurko-tt rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt is a code owner

@uaydonat uaydonat Awaiting requested review from uaydonat uaydonat is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkeerthana0573 @tt-rkim @eyonland @TT-BrianLiu @vigneshkeerthivasanx