Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating encase_derive_impl to use syn@2 #36

Closed
LikeLakers2 opened this issue Apr 1, 2023 · 3 comments · Fixed by #35
Closed

Consider updating encase_derive_impl to use syn@2 #36

LikeLakers2 opened this issue Apr 1, 2023 · 3 comments · Fixed by #35

Comments

@LikeLakers2
Copy link

LikeLakers2 commented Apr 1, 2023

Hi! I noticed that encase_derive_impl (and possibly other parts of this repository) depend on syn@1. Perhaps you could consider updating to use syn@2 wherever possible?

Some things worth noting for anyone who intends to take on this suggestion:

  • syn@2's MSRV is Rust 1.56, up from syn@1's Rust 1.31. I am unsure if this may be a problem - the repository's main Cargo.toml specifies a MSRV of Rust 1.63, but encase_derive and encase_derive_impl do not specify a MSRV.
  • Updating to syn@2 may not be as simple as swapping the version number - there are a number of breaking changes in syn@2, listed at https://github.com/dtolnay/syn/releases/tag/2.0.0.

If you do consider to transition to syn@2, you have my thanks! :)

@teoxoy
Copy link
Owner

teoxoy commented Apr 1, 2023

See #35

@teoxoy teoxoy mentioned this issue Apr 1, 2023
@LikeLakers2
Copy link
Author

Ah, I must've missed that while checking through the repository. My bad!

@teoxoy
Copy link
Owner

teoxoy commented Apr 1, 2023

No worries! Regarding the MSRV, it's the same for the derive crates as it is for the main lib.

@teoxoy teoxoy closed this as completed in #35 May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants