You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! I noticed that encase_derive_impl (and possibly other parts of this repository) depend on syn@1. Perhaps you could consider updating to use syn@2 wherever possible?
Some things worth noting for anyone who intends to take on this suggestion:
syn@2's MSRV is Rust 1.56, up from syn@1's Rust 1.31. I am unsure if this may be a problem - the repository's main Cargo.tomlspecifies a MSRV of Rust 1.63, but encase_derive and encase_derive_impl do not specify a MSRV.
Hi! I noticed that
encase_derive_impl
(and possibly other parts of this repository) depend onsyn@1
. Perhaps you could consider updating to usesyn@2
wherever possible?Some things worth noting for anyone who intends to take on this suggestion:
syn@2
's MSRV is Rust 1.56, up fromsyn@1
's Rust 1.31. I am unsure if this may be a problem - the repository's mainCargo.toml
specifies a MSRV of Rust 1.63, butencase_derive
andencase_derive_impl
do not specify a MSRV.syn@2
may not be as simple as swapping the version number - there are a number of breaking changes insyn@2
, listed at https://github.com/dtolnay/syn/releases/tag/2.0.0.If you do consider to transition to
syn@2
, you have my thanks! :)The text was updated successfully, but these errors were encountered: