-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to syn 2 #35
migrate to syn 2 #35
Conversation
It looks like the failing tests are being compared to older Currently in
This error isn't getting thrown in the new test result, which seems like the correct behavior? Let me know if anything needs to change here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
We shouldn't have to update the expected error files; we seem to lose the span info now.
Having some trouble compiling on my machine now, will resume fixing this later |
@B-Reif I ended up fixing the remaining issues since I wanted to release a new major version with the upgrade to syn2 included. |
Updates
syn
version to"2"
and updates usage.Closes #36.