Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to syn 2 #35

Merged
merged 4 commits into from
May 6, 2023
Merged

migrate to syn 2 #35

merged 4 commits into from
May 6, 2023

Conversation

B-Reif
Copy link
Contributor

@B-Reif B-Reif commented Mar 24, 2023

Updates syn version to "2" and updates usage.

Closes #36.

@B-Reif
Copy link
Contributor Author

B-Reif commented Mar 24, 2023

It looks like the failing tests are being compared to older .stderr files which contain errors related to deriving ShaderType:

Currently in invalid_align_attr.stderr:

error: expected attribute arguments in parentheses: #[align(...)]
 --> tests/compile_fail/invalid_align_attr.rs:5:10
  |
5 | #[derive(ShaderType)]
  |          ^^^^^^^^^^
  |
  = note: this error originates in the derive macro `ShaderType` (in Nightly builds, run with -Z macro-backtrace for more info)

This error isn't getting thrown in the new test result, which seems like the correct behavior? Let me know if anything needs to change here.

Copy link
Owner

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

We shouldn't have to update the expected error files; we seem to lose the span info now.

derive/impl/src/lib.rs Outdated Show resolved Hide resolved
@B-Reif
Copy link
Contributor Author

B-Reif commented Mar 27, 2023

Having some trouble compiling on my machine now, will resume fixing this later

@teoxoy teoxoy merged commit 2446b1f into teoxoy:main May 6, 2023
@teoxoy
Copy link
Owner

teoxoy commented May 6, 2023

@B-Reif I ended up fixing the remaining issues since I wanted to release a new major version with the upgrade to syn2 included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider updating encase_derive_impl to use syn@2
2 participants