Skip to content
This repository has been archived by the owner on Jun 27, 2018. It is now read-only.

fix(reference) support reference import lookup #19

Merged
merged 2 commits into from
Apr 16, 2015

Conversation

basarat
Copy link
Collaborator

@basarat basarat commented Apr 16, 2015

refs #15

teppeis added a commit that referenced this pull request Apr 16, 2015
fix(reference) support reference import lookup
@teppeis teppeis merged commit cbdf39f into teppeis:typescript-1.5 Apr 16, 2015
@teppeis
Copy link
Owner

teppeis commented Apr 16, 2015

@basarat LGTM!

@basarat basarat deleted the patch-1 branch April 16, 2015 03:46
@basarat
Copy link
Collaborator Author

basarat commented Apr 16, 2015

@teppeis is typescript-1.5 branch on NPM?

@basarat
Copy link
Collaborator Author

basarat commented Apr 16, 2015

PS: thanks for adding me as a collab ❤️

@teppeis
Copy link
Owner

teppeis commented Apr 16, 2015

oh, sorry. this pr is for 1.5...

@basarat
Copy link
Collaborator Author

basarat commented Apr 16, 2015

oh, sorry. this pr is for 1.5...

Yeah. Reason is that TS 1.4 completely bails and doesn't give any output considering this a syntactic error.

TS 1.5 on the other hand does give an output.

@teppeis
Copy link
Owner

teppeis commented Apr 16, 2015

@basarat not yet on npm. WIP in #4.

@basarat
Copy link
Collaborator Author

basarat commented Apr 16, 2015

Cool. Fortunately <reference tags are not required anymore now that we tsconfig. So #15 can wait a bit longer.

@teppeis
Copy link
Owner

teppeis commented Apr 16, 2015

@basarat thanks for your investigation!
I'll complete #4 and ship it as v2.0.0-alpha after microsoft/TypeScript#2484 is merged.

@midinastasurazz
Copy link

Does typescript-simple support tsconfig.json? In particular does it respect files specified? I would like to avoid referencing .d.ts files using /// <reference path="..." /> and instead specify them in files in tsconfig.json. Is that possible?

@teppeis
Copy link
Owner

teppeis commented Apr 25, 2015

@midinastasurazz typescript-simple doesn't support for referencing .d.ts. sorry.

@midinastasurazz
Copy link

@teppeis Thanks for the info. What about tsconfig.json? Could the files option be used for referencing .d.ts files? It seems to be supported by TypeScript since 1.5. So does typescript-simple essentially disregard tsconfig.json?

@teppeis
Copy link
Owner

teppeis commented Apr 25, 2015

@midinastasurazz Loading tsconfig.json is a function of tsc command, not of TypeScript Language.
Even if typescript-simple can load it, doesn't support for multiple files structure including d.ts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants