Additional esm package changes #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnoble
changed the title
jsnoble
changed the title
godber
approved these changes
Aug 14, 2024
| @@ -1,19 +1,23 @@ | |||
| import jexlCore from 'jexl'; | |||
| import * as ts from '@terascope/utils'; | |||
| import { | |||
There was a problem hiding this comment.
There are some substantial changes here in this file and not a whole lot of test coverage:
So I am a little concerned that the scope of the changes might not be covered by tests. I'm not going to stop reviewing to consider this in detail at this point but if you want to look back at this a little more closely and consider whether the test coverage is really sufficient that would be excellent.
| should either mock the http response or refactor the code | ||
| to make it easier to mock | ||
| */ | ||
| xdescribe('save', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will refactor in another PR as that could be cascading changes.
eslint-configpackage, the refactor requires a library update that would also force a config change which will have an impact on this codebase as well as our others as well