Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node version check in k8s --dev mode #3701

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Fix node version check in k8s --dev mode #3701

merged 4 commits into from
Jul 26, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jul 24, 2024 •
edited
Loading

This PR makes the following changes:

  • Fixes bug when running ts-scripts k8s --dev that will fail when env variable NODE_VERSION is a major version
    • Before, this check only expected full semver versions
  • Added kind cleanup in error scenarios
  • Bumps @terascope/scripts from v0.83.0 to v0.83.1

@sotojn sotojn self-assigned this Jul 24, 2024
@sotojn sotojn marked this pull request as ready for review July 25, 2024 20:55
@sotojn sotojn requested review from godber and busma13 July 25, 2024 20:55
busma13
busma13 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@busma13 busma13 mentioned this pull request Jul 26, 2024
Merged
godber pushed a commit that referenced this pull request Jul 26, 2024
@busma13
Allow for empty lists in /images/images-list.txt (#3705)
dcfda3b 
This PR makes the following changes:
- allows empty lists to be created in `scripts images list`
- prevents `scripts images save` from failing on an empty string.

This allows any repo that doesn't require images to use workflows using
these commands without failing

Waiting on #3701 so I can bump scripts again
@godber godber merged commit 6792a38 into master Jul 26, 2024
62 checks passed
@godber godber deleted the k8s-dev-option-bug-fix branch July 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@busma13 busma13 busma13 approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13