rework generateTSConfig #3703
Merged
rework generateTSConfig #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesleydreyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generateTSConfig writes to commonjs.
Ideas were to...
A) check the package.json and adjust the compilerOptions to module/target/resolution to nodenext/esnext if it's a module
B) remove generateTSConfig completely
C) keep some options
We looked at the git history and weren't completely clear why generating a tsconfig is needed since we already do what it's doing in the tsconfigs, so decided maybe keeping the references and just allow the original options for the rest.