Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert execution controller IP to a k8s service in kubernetesV2 backend #3718

Merged
merged 9 commits into from
Aug 16, 2024
Merged

Convert execution controller IP to a k8s service in kubernetesV2 backend #3718

merged 9 commits into from
Aug 16, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Aug 12, 2024 •
edited
Loading

This PR makes the following changes:

  • Makes V2 backend compatible with --dev option
  • Bumps teraslice from v2.1.0 v2.2.0
  • Replaces ex pod_ip host name with static k8s service host name
    • This allows workers to reconnect with an execution_controller pod when an execution controller fails and creates a new pod
    • NOTE: These changes only apply when the clustering_type is set to kubernetesV2

Ref to issue #3696

@sotojn sotojn self-assigned this Aug 12, 2024
@sotojn sotojn marked this pull request as ready for review August 14, 2024 14:56
@godber godber merged commit 71ebd9b into master Aug 16, 2024
67 checks passed
@godber godber deleted the ex-service-k8s-v2 branch August 16, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotojn @godber