Eslint plugin style fixes #3757

jsnoble · 2024-09-17T22:46:35Z

No description provided.

jest.config.base.js

sotojn · 2024-09-26T17:19:25Z

Here are logs from when the shutdown emitter is called from the ex server when window is in the jest config:

2024-09-26T16:57:28.847Z socket.io-parser encoding packet {"type":2,"data":["shutdown"],"nsp":"/"}
2024-09-26T16:57:28.847Z socket.io-parser encoded {"type":2,"data":["shutdown"],"nsp":"/"} as 2["shutdown"]
2024-09-26T16:57:28.847Z socket.io:client writing packet ["2[\"shutdown\"]"]
  console.log
    @@@@@ this.server.volatile.emit("shutdown") ran 1 times!

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:125:17)

  console.log
    @@@ after  this.server.volatile.emit("shutdown");

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:126:17)

  console.log
    @@@@@@@@@@@@@@ isTest:  true

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:127:17)

2024-09-26T16:57:28.850Z socket.io-client:manager writing packet {"type":2,"data":["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}],"options":{"compress":true},"nsp":"/"}
2024-09-26T16:57:28.851Z socket.io-parser encoding packet {"type":2,"data":["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}],"options":{"compress":true},"nsp":"/"}
2024-09-26T16:57:28.851Z socket.io-parser encoded {"type":2,"data":["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}],"options":{"compress":true},"nsp":"/"} as 2["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]
2024-09-26T16:57:28.851Z engine.io-client:socket flushing 1 packets in socket
2024-09-26T16:57:28.851Z engine.io-client:polling-xhr xhr open POST: http://localhost:18016/socket.io/?clientId=192.168.12.97__CxLISLvs&clientType=worker&EIO=3&transport=polling&t=P8lH2WJ&b64=1&sid=p_icGoupRILiYoA3AAAA
2024-09-26T16:57:28.851Z engine.io-client:polling-xhr xhr data 204:42["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]
2024-09-26T16:57:28.851Z engine intercepting request for path "/socket.io/"
2024-09-26T16:57:28.851Z engine handling "GET" http request "/socket.io/?clientId=192.168.12.97__CxLISLvs&clientType=worker&EIO=3&transport=polling&t=P8lH2Vs&b64=1&sid=p_icGoupRILiYoA3AAAA"
2024-09-26T16:57:28.851Z engine setting new request for existing client
2024-09-26T16:57:28.851Z engine:polling setting request
2024-09-26T16:57:28.851Z engine:socket executing batch send callback
2024-09-26T16:57:28.852Z engine intercepting request for path "/socket.io/"
2024-09-26T16:57:28.852Z engine handling "POST" http request "/socket.io/?clientId=192.168.12.97__CxLISLvs&clientType=worker&EIO=3&transport=polling&t=P8lH2WJ&b64=1&sid=p_icGoupRILiYoA3AAAA"
2024-09-26T16:57:28.852Z engine setting new request for existing client
2024-09-26T16:57:28.852Z engine:polling received "204:42["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]"
2024-09-26T16:57:28.852Z engine:socket packet
2024-09-26T16:57:28.852Z socket.io-parser decoded 2["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}] as {"type":2,"nsp":"/","data":["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]}
2024-09-26T16:57:28.852Z socket.io:socket got packet {"type":2,"nsp":"/","data":["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]}
2024-09-26T16:57:28.852Z socket.io:socket emitting event ["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]
2024-09-26T16:57:28.852Z socket.io:socket dispatching an event ["client:available",{"id":"oddkx76Mv4","eventName":"client:available","from":"192.168.12.97__CxLISLvs","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]
2024-09-26T16:57:28.852Z socket.io:client writing packet {"type":2,"data":["message:response",{"id":"oddkx76Mv4","eventName":"client:available","from":"ExecutionController","to":"192.168.12.97__CxLISLvs","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}],"nsp":"/"}
2024-09-26T16:57:28.852Z socket.io-parser encoding packet {"type":2,"data":["message:response",{"id":"oddkx76Mv4","eventName":"client:available","from":"ExecutionController","to":"192.168.12.97__CxLISLvs","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}],"nsp":"/"}
2024-09-26T16:57:28.852Z socket.io-parser encoded {"type":2,"data":["message:response",{"id":"oddkx76Mv4","eventName":"client:available","from":"ExecutionController","to":"192.168.12.97__CxLISLvs","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}],"nsp":"/"} as 2["message:response",{"id":"oddkx76Mv4","eventName":"client:available","from":"ExecutionController","to":"192.168.12.97__CxLISLvs","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}]
2024-09-26T16:57:28.852Z engine:socket sending packet "message" (2["message:response",{"id":"oddkx76Mv4","eventName":"client:available","from":"ExecutionController","to":"192.168.12.97__CxLISLvs","payload":{},"volatile":true,"response":true,"respondBy":1727369850950}])
2024-09-26T16:57:28.852Z engine:socket flushing buffer to transport

Here is when window is removed from the jest config:

    @@@ before this.server.volatile.emit("shutdown");

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:117:17)

2024-09-26T17:14:32.496Z socket.io-parser encoding packet {"type":2,"data":["shutdown"],"nsp":"/"}
2024-09-26T17:14:32.496Z socket.io-parser encoded {"type":2,"data":["shutdown"],"nsp":"/"} as 2["shutdown"]
2024-09-26T17:14:32.496Z socket.io:client writing packet ["2[\"shutdown\"]"]
2024-09-26T17:14:32.496Z engine:socket sending packet "message" (2["shutdown"])
2024-09-26T17:14:32.496Z engine:socket flushing buffer to transport
2024-09-26T17:14:32.496Z engine:ws writing "42["shutdown"]"
  console.log
    @@@@@ this.server.volatile.emit("shutdown") ran 1 times!

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:125:17)

  console.log
    @@@ after  this.server.volatile.emit("shutdown");

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:126:17)

  console.log
    @@@@@@@@@@@@@@ isTest:  true

      at Server.log (packages/teraslice-messaging/dist/src/messenger/server.js:127:17)

2024-09-26T17:14:32.497Z socket.io-client:manager writing packet {"type":2,"data":["client:available",{"id":"xoce4tlaV_","eventName":"client:available","from":"192.168.12.97__c6hxCmx7","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727370874570}],"options":{"compress":true},"nsp":"/"}
2024-09-26T17:14:32.497Z socket.io-parser encoding packet {"type":2,"data":["client:available",{"id":"xoce4tlaV_","eventName":"client:available","from":"192.168.12.97__c6hxCmx7","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727370874570}],"options":{"compress":true},"nsp":"/"}
2024-09-26T17:14:32.497Z socket.io-parser encoded {"type":2,"data":["client:available",{"id":"xoce4tlaV_","eventName":"client:available","from":"192.168.12.97__c6hxCmx7","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727370874570}],"options":{"compress":true},"nsp":"/"} as 2["client:available",{"id":"xoce4tlaV_","eventName":"client:available","from":"192.168.12.97__c6hxCmx7","to":"ExecutionController","payload":{},"volatile":true,"response":true,"respondBy":1727370874570}]
2024-09-26T17:14:32.497Z engine.io-client:socket flushing 1 packets in socket
2024-09-26T17:14:32.497Z engine.io-client:socket socket receive: type "message", data "2["shutdown"]"
2024-09-26T17:14:32.497Z socket.io-parser decoded 2["shutdown"] as {"type":2,"nsp":"/","data":["shutdown"]}
2024-09-26T17:14:32.497Z socket.io-client:socket emitting event ["shutdown"]
2024-09-26T17:14:32.497Z teraslice:worker:messaging:client [DEBUG] server ExecutionController shutdown
2024-09-26T17:14:32.497Z teraslice:worker [WARN] Execution Controller shutdown, exiting...
2024-09-26T17:14:32.497Z socket.io-client:socket performing disconnect (/)
2024-09-26T17:14:32.497Z socket.io-client:manager writing packet {"type":1,"nsp":"/"}
2024-09-26T17:14:32.497Z socket.io-parser encoding packet {"type":1,"nsp":"/"}
2024-09-26T17:14:32.497Z socket.io-parser encoded {"type":1,"nsp":"/"} as 1
2024-09-26T17:14:32.497Z socket.io-client:manager disconnect
2024-09-26T17:14:32.497Z socket.io-client:socket close (io client disconnect)
2024-09-26T17:14:32.498Z teraslice:worker:messaging:client [INFO] client 192.168.12.97__c6hxCmx7 disconnected { reason: 'io client disconnect' }

package.json

sotojn

Once Peter's requested changes are in it looks good

jsnoble added 7 commits September 13, 2024 15:52

gettinng typescript plugin to work as service

3775c04

first round of style fixes

0dc1af7

eslint fixes

9e17b58

eslint fixes

ef8cb10

finish adding rules for react and styles in this round of changes

27a973e

merge master

29bc1d6

fix lint

a25a01e

jsnoble changed the title ~~Draft: Eslint plugin style fixes~~ Eslint plugin style fixes Sep 23, 2024

jsnoble added 4 commits September 23, 2024 09:29

bump: (minor) @terascope/eslint-config@1.1.0

caa770f

fix tests

f407669

fix deploy tests

3b25913

fix react rules and fix test

d2a7b35

busma13 reviewed Sep 26, 2024

View reviewed changes

jest.config.base.js Outdated Show resolved Hide resolved

remove delays and move window global mock to eslint-config

0373c98

busma13 requested changes Sep 26, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

sotojn approved these changes Sep 26, 2024

View reviewed changes

Revert lint script debug option in package.json

e8bd056

busma13 approved these changes Sep 26, 2024

View reviewed changes

jsnoble merged commit 8a6c703 into master Sep 26, 2024
67 checks passed

jsnoble deleted the eslint-plugin-style-fixes branch September 26, 2024 19:22

jsnoble temporarily deployed to github-pages September 26, 2024 19:37 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eslint plugin style fixes #3757

Eslint plugin style fixes #3757

jsnoble commented Sep 17, 2024

sotojn commented Sep 26, 2024

sotojn left a comment

Eslint plugin style fixes #3757

Eslint plugin style fixes #3757

Conversation

jsnoble commented Sep 17, 2024

sotojn commented Sep 26, 2024

sotojn left a comment

Choose a reason for hiding this comment