Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teraslice, teraslice-client-js, terafoundation, scripts] update got from 11.8.3 to 13.0.0 #3776

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Sep 27, 2024

This PR makes the following changes:

  • update got from 11.8.3 to 13.0.0.
  • remove gotESM module workaround from teraslice api.ts
  • replace use of the removed query option field with searchParams.
  • since query is no longer an option RequestOptions and SearchOptions types were identical. They are just a partial list of all got options. I chose to keep RequestOptions because that is more general. Requests that make a search still use a parameter named searchOptions, but it is now of type RequestOptions.
  • timeout and reply options now take objects.
  • add path to got types in tsconfig.js. Without this types are taken from @types/got which is a dependency of kubernetes-client. We can remove this once we go to kubernetesV2.

Note: got 14 requires node 20+, so we can only update to 13 at this time.

@godber godber added this to the Teraslice 2.4.0 milestone Sep 30, 2024
@busma13 busma13 changed the title update got from 11.8.3 to 13.0.0 [teraslice, teraslice-client-js, terafoundation, scripts] update got from 11.8.3 to 13.0.0 Sep 30, 2024
@busma13 busma13 marked this pull request as ready for review September 30, 2024 20:00
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godber godber merged commit fc80a6d into master Sep 30, 2024
67 checks passed
@godber godber deleted the update-got branch September 30, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants