Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scripts, teraslice-cli] update glob dependencies #3779

Merged
merged 3 commits into from
Oct 1, 2024
Merged

[scripts, teraslice-cli] update glob dependencies #3779

merged 3 commits into from
Oct 1, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Sep 30, 2024 •
edited
Loading

This PR makes the following changes:

  • scripts
    • update globby from 11.0.4 to 14.0.2
    • globby.sync() is now globbySync()
    • globby.hasMagic() is now isDynamicPattern()
  • teraslice-cli
    • remove glob and glob-promise dependencies in favor of globby@14.0.2.

ref: #3766

@busma13 busma13 changed the title Update glob dependencies [scripts, teraslice-cli] update glob dependencies Sep 30, 2024
@busma13 busma13 requested review from jsnoble and godber October 1, 2024 16:33
@busma13 busma13 marked this pull request as ready for review October 1, 2024 16:34
jsnoble
jsnoble approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit a842e78 into master Oct 1, 2024
68 checks passed
@jsnoble jsnoble deleted the update-glob-dependencies branch October 1, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

@godber godber Awaiting requested review from godber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @jsnoble