Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-mate, utils] update ip-bigint from 3.0.3 to 8.2.0 #3781

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Oct 1, 2024

This PR makes the following changes:

  • update ip-bigint from 3.0.3 to 8.2.0
  • import names updated: parse -> parseIP, stringify -> stringifyIp
  • parseIp no longer validates an IP with the isIP library, so we add a check before calling the function.
  • stringifyIp no longer validates that a bigint is greater than 0n or that it's not bigger than the largest IP address of its version, so a check was added for those.
  • remove unneeded types files

ref: #3304

@busma13 busma13 marked this pull request as ready for review October 1, 2024 21:58
@busma13 busma13 requested a review from jsnoble October 1, 2024 22:53
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit 943ad99 into master Oct 2, 2024
66 checks passed
@jsnoble jsnoble deleted the update-ip-bigint branch October 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants