Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data-mate, utils, xlucene-parser] update date-fns and date-fns-tz #3783

Merged
merged 3 commits into from
Oct 2, 2024
Merged

[data-mate, utils, xlucene-parser] update date-fns and date-fns-tz #3783

merged 3 commits into from
Oct 2, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Oct 1, 2024

This PR makes the following changes:

  • update date-fns from 2.30.0 to 4.1.0
  • update date-fns-tz from 1.3.7 to 3.2.0
  • switch to named imports
  • parse() now only accepts strings, so _parseDate will convert inputs of type number to strings.

@busma13 busma13 requested review from jsnoble and lesleydreyer and removed request for lesleydreyer October 1, 2024 22:52
@busma13 busma13 marked this pull request as ready for review October 1, 2024 22:54
jsnoble
jsnoble approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busma13 busma13 merged commit fdd7ea5 into master Oct 2, 2024
67 checks passed
@busma13 busma13 deleted the update-date-fns branch October 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @jsnoble