Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mvc:exclude-mapping Definition of interceptors in spring-mvc.xml for security #348 #415

Conversation

btkomatsubaratka
Copy link
Contributor

Please review #348.

@btkomatsubaratka btkomatsubaratka changed the title Improve spring mvc exclude setting #348 Improve mvc:exclude-mapping Definition of interceptors in spring-mvc.xml for security #348 Mar 29, 2018
@btkomatsubaratka btkomatsubaratka self-assigned this Mar 29, 2018
Copy link
Contributor

@yoshikawaa yoshikawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btkomatsubaratka (or person who took over)
Please check.

<bean
class="org.terasoluna.gfw.web.logging.TraceLoggingInterceptor" />
</mvc:interceptor>
<mvc:interceptor>
<mvc:mapping path="/**" />
<mvc:exclude-mapping path="/resources/**" />
<mvc:exclude-mapping path="/**/*.html" />
<bean
class="org.terasoluna.gfw.web.token.transaction.TransactionTokenInterceptor" />
</mvc:interceptor>
Copy link
Contributor

@yoshikawaa yoshikawaa Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshikawaa
I fixed it because I have the same opinon as your comment.
a6bf294

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshikawaa
I confirmed the fixing.

@hirakuriy hirakuriy merged commit e2a54e7 into master Sep 3, 2018
@hirakuriy hirakuriy deleted the issues/348_improve_mvc_exclude-mapping_definition_of_interceptors_in_spring-mvc_xml_for_security branch September 3, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants