Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cargo-maven2-plugin #451

Closed
3 tasks done
kazuki43zoo opened this issue Dec 19, 2015 · 3 comments
Closed
3 tasks done

Support cargo-maven2-plugin #451

kazuki43zoo opened this issue Dec 19, 2015 · 3 comments
Assignees
@btshimizukza
Labels
type: misc
Milestone
1.0.4

Comments

@kazuki43zoo
Copy link
Contributor

Description

Add plugin management for cargo-maven2-plugin.

Note:
Separated from #318 .

Possible Solutions

For details, refer to #318 (comment).

Affects Version/s

N/A

Fix Version/s

  • 5.1.0 (Replace instead of tomcat7-maven-plugin)
  • 5.0.2
  • 1.0.4

Issue Links
@kazuki43zoo kazuki43zoo added this to the 5.1.0 milestone Dec 19, 2015
@kazuki43zoo kazuki43zoo mentioned this issue Dec 19, 2015
Closed
1 task
@kazuki43zoo
Copy link
Contributor Author

I want to backport to 5.0.x and 1.0.x for improving maintainability on other project (e.g. terasoluna-gfw-functionaltest, terasoluna-tourreservation, etc ...).
What do you think ?

@ikeyat
Copy link
Contributor

ikeyat commented Dec 19, 2015

In my opinion, we need to take care for existing users.
My idea is that add cargo-maven2-plugin as <dependencyManagement> for all versions but keep tomcat7-maven-plugin on 5.0.x and 1.0.x.

@kazuki43zoo
Copy link
Contributor Author

@ikeyat i agree your opinion!

@kazuki43zoo kazuki43zoo modified the milestones: 1.0.4, 5.1.0 Dec 19, 2015
kazuki43zoo added a commit that referenced this issue Dec 19, 2015
@kazuki43zoo
Add pluginManagement of cargo-maven2-plugin #451
b5201f8
kazuki43zoo added a commit that referenced this issue Dec 19, 2015
@kazuki43zoo
Remove tomcat7-maven-plugin #451
c4856f4
@kazuki43zoo kazuki43zoo mentioned this issue Dec 19, 2015
Merged
@ikeyat ikeyat mentioned this issue Dec 21, 2015
Closed
5 tasks
ikeyat added a commit that referenced this issue Dec 21, 2015
@ikeyat
Merge pull request #453 from terasolunaorg/issues/451_support-cargo
a922446 
Support cargo-maven2-plugin instead of tomcat7-maven-plugin #451
@btshimizukza btshimizukza mentioned this issue Dec 21, 2015
Closed
3 tasks
kazuki43zoo added a commit that referenced this issue Dec 21, 2015
@kazuki43zoo @btshimizukza
Add pluginManagement of cargo-maven2-plugin #451
e062f7c 
(cherry picked from commit b5201f8)
btshimizukza added a commit that referenced this issue Dec 21, 2015
@btshimizukza
Add pluginManagement of cargo-maven2-plugin #451
f97e952
This was referenced Dec 21, 2015
Merged
Merged
ikeyat added a commit that referenced this issue Dec 21, 2015
@ikeyat
Merge pull request #454 from terasolunaorg/issues/451_support-cargo-5…
922f40d 
….0.x

[5.0.x] Add pluginManagement of cargo-maven2-plugin #451
ikeyat added a commit that referenced this issue Dec 21, 2015
@ikeyat
Merge pull request #455 from terasolunaorg/issues/451_support-cargo-1…
7f1d30a 
….0.x

[1.0.x] Add pluginManagement of cargo-maven2-plugin #451
@ikeyat ikeyat closed this as completed Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btshimizukza btshimizukza

Labels
type: misc
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
4 participants
@kazuki43zoo @btshimizukza @ikeyat @btkobayashitkzp