Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hamcrest 2.x #950

Closed
1 task done
yoshikawaa opened this issue Jan 6, 2020 · 0 comments
Closed
1 task done

Upgrade to hamcrest 2.x #950

yoshikawaa opened this issue Jan 6, 2020 · 0 comments

Comments

@yoshikawaa
Copy link
Contributor

yoshikawaa commented Jan 6, 2020

Description

<!-- == Begin Unit Test == -->
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-all</artifactId>
<version>${hamcrest.version}</version>
</dependency>
<!-- == Begin Unit Test == -->

<!-- == Unit Test == -->
<hamcrest.version>1.3</hamcrest.version>

Now, Terasoluna use Hamcrest 1.3.

https://docs.spring.io/spring-boot/docs/2.2.2.RELEASE/reference/htmlsingle/#dependency-versions-coordinates
Spring boot 2.2.x use Hamcrest 2.1.

http://hamcrest.org/JavaHamcrest/distributables.html#previous-versions-of-hamcrest
http://hamcrest.org/JavaHamcrest/distributables.html#upgrading-from-hamcrest-1x
Hamcrest 2.x change in packaging all classes only 1 jar.

  • hamcrest-core -> hamcrest-core or hamcrest
  • hamcrest-library -> hamcrest-library or hamcrest
  • hamcrest-all -> hamcrest

Possible Solutions

I recommend as follows:

all of our project

move dependency of hamcrest-* to hamcrest.

the migration guide

compatibility is maintained even if using hamcrest-core or hamcrest-library as before, but basically it is announced that it is recommended to move to hamcrest.

Affects Version/s

  • None

Fix Version/s

  • 5.6.0 (master)

Issue Links

  • #XXX
yoshikawaa added a commit that referenced this issue Jan 14, 2020
btyanagawamg pushed a commit that referenced this issue Jan 14, 2020
takahashihrzg added a commit that referenced this issue Jan 15, 2020
* fix convert of Boolean #846

* fix Boolean convert method #846

* fix name for test of Boolean convert #846

* Drop Oracle JDK from Travis CI #923

* Upgrade Spring Boot 2.2.0.RELEASE #925

* Remove tomcat dependencyManagement that define our own version #925

* [DATACMNS-1496] apply removed deprecations at Spring Data Commons 2.2 #926

* Modify from http to https #930 (#931)

* update self defined libraries #933 (#934)

* Upgrade Spring Boot 2.2.2.RELEASE #935

* update sequence processing to match H2 specifications #936

* upgrade tomcat used in cargo #935

* add dependency of java mail #945

* fix dependency position of java mail #945

* not use static import that not needed #925

* difine properties first #925

* remove log4jdbc-remix #947

* remove property of log4jdbc #947

* Exclude javax.activation:activation and add com.sun.activation:javax.activation 1.2.0 #945

* change to use properties #945

* Upgrade to hamcrest 2.x #950 (#955)

* Manage dependency Bouncy Castle Provider. #953 (#956)

Co-authored-by: btkobayashirun <Ryuusuke.Kobayashi.bp@nttdata.com>
Co-authored-by: btyanagawamg <Mugi.Yanagawa.bp@nttdata.com>
Co-authored-by: takahashihrzg <Hironobu.Takahashi@nttdata.com>
Co-authored-by: bthabukar <39939101+bthabukar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants