Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionTokenContext deprecated. #593 #594

Merged
merged 2 commits into from
Jul 25, 2016
Merged

TransactionTokenContext deprecated. #593 #594

merged 2 commits into from
Jul 25, 2016

Conversation

btkobayashirun
Copy link
Contributor

Please review #593 .

@coveralls
Copy link

coveralls commented Jul 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.692% when pulling 05c9020 on issues/593_TransactionTokenContextDeprecated into 11947b8 on master.

@yoshikawaa
Copy link
Contributor

@btkobayashirun
Please correspond follows.

  • Rebase current master.
  • Resolve sonarqube major issues. Message is Deprecation should be marked with both the @Deprecated annotation and @deprecated Javadoc tag. The annotation enables tools such as IDEs to warn about referencing deprecated elements, and the tag can be used to explain when it was deprecated, why, and how references should be refactored.

@yoshikawaa yoshikawaa force-pushed the issues/593_TransactionTokenContextDeprecated branch from 05c9020 to 6f01147 Compare July 25, 2016 11:52
@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 96.705% when pulling 6f01147 on issues/593_TransactionTokenContextDeprecated into 1bfc837 on master.

@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.66% when pulling 8435d6e on issues/593_TransactionTokenContextDeprecated into 1bfc837 on master.

@yoshikawaa yoshikawaa force-pushed the issues/593_TransactionTokenContextDeprecated branch from 8435d6e to 5e0eedd Compare July 25, 2016 12:26
@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.66% when pulling 5e0eedd on issues/593_TransactionTokenContextDeprecated into a49f405 on master.

@yoshikawaa yoshikawaa mentioned this pull request Jul 25, 2016
Merged
@ikeyat ikeyat merged commit fb5fa88 into master Jul 25, 2016
@ikeyat ikeyat deleted the issues/593_TransactionTokenContextDeprecated branch July 25, 2016 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btkobayashirun @coveralls @yoshikawaa @ikeyat