Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dependency jackson-datatype-joda to gfw-jodatime-dependencies #736 #837

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Move dependency jackson-datatype-joda to gfw-jodatime-dependencies #736 #837

merged 1 commit into from
Mar 5, 2019

Conversation

btiwahorisu
Copy link
Contributor

@btiwahorisu btiwahorisu commented Oct 9, 2018 •
edited
Loading

Please review #736 .

fix as described in Issue.
After merging, do backport.

@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 98.987% when pulling 8284701 on issues/736_fix_dependency_jodatime into e4ac12e on master.

btyanagawamg
btyanagawamg requested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@btyanagawamg btyanagawamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btiwahorisu
Please check .

terasoluna-gfw-common-libraries/terasoluna-gfw-jodatime/pom.xml Outdated Show resolved Hide resolved
@yoshikawaa
Copy link
Contributor

@btiwahorisu fix dependency is wrong...
Please correct commit messages to describe change details.

@yoshikawaa
Copy link
Contributor

@btiwahorisu @hirakuriy
I think that it's better to do #736 and #737 one timing as correcting dependencies of jackson-datatype.

@yoshikawaa yoshikawaa mentioned this pull request Dec 5, 2018
Closed
2 tasks
@btiwahorisu btiwahorisu self-assigned this Mar 4, 2019
yoshikawaa
yoshikawaa requested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@yoshikawaa yoshikawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btiwahorisu Please check.

terasoluna-gfw-dependencies/terasoluna-gfw-jodatime-dependencies/pom.xml Show resolved Hide resolved
@yoshikawaa
Copy link
Contributor

yoshikawaa commented Mar 5, 2019 •
edited
Loading

I think that it's better to do #736 and #737 one timing as correcting dependencies of jackson-datatype.

Unfortunately, TERASOLUNA 5.5.1 can't support JSR310 completely.(DateFactory, JSP tags,,,)
So we want to correspond #736 and #737 separately.

@btiwahorisu btiwahorisu changed the title fix dependency #736 Move dependency jackson-datatype-joda to gfw-jodatime-dependencies #736 Mar 5, 2019
@btiwahorisu btiwahorisu force-pushed the issues/736_fix_dependency_jodatime branch from f4f5d9b to 8284701 Compare March 5, 2019 01:39
@yoshikawaa yoshikawaa merged commit 56805e0 into master Mar 5, 2019
@yoshikawaa yoshikawaa deleted the issues/736_fix_dependency_jodatime branch March 5, 2019 02:20
btiwahorisu added a commit that referenced this pull request Mar 5, 2019
@btiwahorisu
move dependency jacson-datatype-joda to gfw-jodatime-dependencies #736 (
d0ae7e1 
#837)

(cherry picked from commit 56805e0)
yoshikawaa pushed a commit that referenced this pull request Mar 5, 2019
@btiwahorisu @yoshikawaa
move dependency jacson-datatype-joda to gfw-jodatime-dependencies #736 (
15db52c 
#837) (#876)

(cherry picked from commit 56805e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btyanagawamg btyanagawamg btyanagawamg approved these changes

@yoshikawaa yoshikawaa yoshikawaa approved these changes

@hirakuriy hirakuriy Awaiting requested review from hirakuriy

Assignees

@btiwahorisu btiwahorisu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@btiwahorisu @coveralls @yoshikawaa @btyanagawamg @ikeyat