feat(setlistfm-js): Add option to specify a base url #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terhuerne
reviewed
Jul 29, 2019
| @@ -399,6 +399,11 @@ var SetlistFmApi = function(config) { | |||
| } | |||
|
|
|||
| // Constructor Actions | |||
| self.baseUrl = defaultBaseUrl; | |||
| if (typeof config !== "undefined" && typeof config.baseUrl !== "undefined") { | |||
| self.baseUrl = config.baseUrl || defaultBaseUrl; | |||
There was a problem hiding this comment.
@jamsea Please don't assign "defaultBaseUrl" as a fallback for this check, because this is not necessary. You already assign "defaultBaseUrl" in line 402 to "self.baseUrl" and the check in line 403 for "config.baseUrl to be defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setlist.fm is blocking API requests because of CORS https://www.setlist.fm/forum/setlistfm/setlistfm-api/api-cross-origin-request-blocked-1bd6c540
This allows you to set a different baseUrl so you can mirror their API on your server and avoid exposing your API key.