Fix fingerprint APIs on android 9 and switch to android X #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2019
|
What's the status on this? |
And probably require more testing unless some people confirm here that it works. |
|
I was asking what's the status on fixing the conflicts.. 😂 |
|
Resolved |
|
@danog thanks! |
|
ping, could someone merge this |
ghost
requested a review
from
This comment has been minimized.
This comment has been minimized.
ghost
approved these changes
Sep 24, 2019
@danog Do these help? #246 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fingerprint scanning on android 9 by implementing the BiometricPrompt APIs.
The Fingerprint wrapper now supports setting a custom prompt title, subtitle, description and cancel button text (w/ termux/termux-api-package#81).
Also upgraded the compat libraries, now using the recommended androidx.
Techincally, I should've probably substituted the FingerprintManager API with the BiometricManager API, but the androidx compat BiometricManager polyfill hasn't been released yet, and I didn't fill like changing the SDK target to android Q just yet, so for now I just switched to the FingerprintCompat library for sensor detection.
Fixes #261
P.S. I also kinda wanted to implement #246, but I wasn't sure on how exactly to go about it, since transmitting the secrets to the API via a public intent didn't seem exactly secure to me.
I welcome suggestions <3<3<3