android 10 branch forking

[simbadMarino]

Hello termux devs and community, I finally decided to move from updated flavor branch to android10 as per @agnostic-apollo recommendation but I’m having some issues when running the TermuxActivity. Not sure if I need to modify the $PREFIX at android/pkg.sh . It’s not executing the login as usual and everything looks empty. Seems like symlinks are not available as well. I hope anyone here can give me a light on what could be the root cause of the issue. I’m adding a screenshot and execution log file

android10 log.txt

[agnostic-apollo]

Didn't you get the updated-flavor branch working after the patches?

[simbadMarino]

Sorry, I'm trying to understand what you are pointing at... the sharedUserId for sure I got it from the updated-flavour , maybe i didnt understand it's purpose and need to remove it?
About the customer permissions of com.termux what do you mean? As far as I remember I had to keep the com.termux package name as I'm still keeping most of the termux code intact.

If I understood from the definition of what a sharedUserId is I will have installing conflicts, etc with the official termux app (I actually noticed this problem in the past but pushed it for future analysis). Do you sugget to just remove this line in the manifest and to have a default one generated by the Android system?

[agnostic-apollo]

By using the same sharedUserId, your app and termux apps are granted the same user id by android and can directly access each others data. Android would not allow installation if there is signature difference between your APK and termux APKs. At this point, you can't just remove the line, since that what imply your app should be assigned a different user id, which won't be possible unless all your users uninstall your app and reinstall the app with an APK that does not have com.termux sharedUserId. It may be possible in android 13, but not on earlier versions.

The docs were clear that you must change TERMUX_PACKAGE_NAME manifest placeholder.

https://github.com/simbadMarino/dCloud/blob/9af654871e4a9697a3acdf7b7b052de34880975e/android/termux-shared/src/main/java/com/termux/shared/termux/TermuxConstants.java#L157

About the customer permissions of com.termux what do you mean? As far as I remember I had to keep the com.termux package name as I'm still keeping most of the termux code intact.

Your app should have its own custom permissions (com.<package_name>.RUN_COMMAND) declared. Android does not allow two apps with the same permission declared to be installed unless they share the same sharedUserId due to security reasons.

As for package="com.termux" in AndroidManifest.xml, its mainly used at compile time for .TermuxActivity expansion. You have already changed that and are using full com.termux.app.TermuxActivity class declarations, so that's not an issue. Once APK is build the package value is replaced by applicationId in the AndroidManifest.xml of the APK.

I suggest you read https://developer.android.com/studio/build/configure-app-module

You probably won't be allowed to publish on playstore either due to conflicts, since I think only fornwall's account should be allowed to publish app with that user id, at least that would be a good security practice.

[simbadMarino]

Thanks again for your feedback @agnostic-apollo , so the last 2 days I've been trying to get the sharedUserId problem fixed without success... I followed the TermuxConstant guidelines thoughtfully and changed all hardcoded com.termux every time I try to change the the sharedUserId I get the following error:

W/dCloud:SharedProperties: Not loading properties since file is null
E/FMQ: grantorIdx must be less than 3
D/CCodecBufferChannel: [c2.android.vorbis.decoder#733] MediaCodec discarded an unknown buffer
I/chatty: uid=10173(com.justshare) NDK MediaCodec_ identical 1 line
D/CCodecBufferChannel: [c2.android.vorbis.decoder#733] MediaCodec discarded an unknown buffer
I/hw-BpHwBinder: onLastStrongRef automatically unlinking death recipients
D/BufferPoolAccessor2.0: bufferpool2 0x7d9d56a268 : 0(0 size) total buffers - 0(0 size) used buffers - 3/9 (recycle/alloc) - 6/24 (fetch/transfer)
D/BufferPoolAccessor2.0: evictor expired: 1, evicted: 1

As soon as I change the TERMUX_PACKAGE_NAME manifest placeholder terminal is not properly loaded and the error above pops up.

Is there something else I need to change in the com.termux.shared I need to modify maybe?

[agnostic-apollo]

Another bug, clean gradle task does not clear app/src/main/jniLibs/, so any package files that are not overridden may remain there and consume space in apk, although shouldn't be extracted to prefix because of not existing in libfiles.so. Requires a patch like following, assuming there are no other libs in jniLibs. Also not cleaning zips, since one may have custom ones there.

https://github.com/termux/termux-app/blob/updated-flavor/app/build.gradle

clean {
    doLast {
        def tree = fileTree(new File(projectDir, 'src/main'))
        //tree.include 'bootstraps/bootstrap-*.zip'
        tree.include 'bootstraps/bootstrap-*.zip.*.done'
        tree.include 'jniLibs/*/*'
        tree.each { it.delete() }
    }
}

[simbadMarino]

Nice, I noticed it wasn’t removing those and sometimes I used to clean them up manually (specially when releasing a new apk) I will include this change in the next iteration! Thank you!