Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilesAnalyzed: False has a wrong case for "False" #1170

Closed
vargenau opened this issue Jun 6, 2022 · 3 comments · Fixed by #1171
Closed

FilesAnalyzed: False has a wrong case for "False" #1170

vargenau opened this issue Jun 6, 2022 · 3 comments · Fixed by #1171

Comments

@vargenau
Copy link
Contributor

vargenau commented Jun 6, 2022

Describe the bug
Tern sometimes generates FilesAnalyzed: False instead of FilesAnalyzed: false

To Reproduce
Steps to reproduce the behavior:

tern report -f spdxtagvalue -i mariadb:latest -o mariadb.spdx

Expected behavior
In SPDX 2.2, section 1.7.7, it is stated: "Tags and format properties are case sensitive".

So boolean false should be in lower case like in the examples.

Environment you are running Tern on

Tern version 2.10.0
   python version = 3.10.4 (main, Apr  2 2022, 09:04:19) 

Please attach files if they exist

  • tern.log
  • report.*
@rnjudge
Copy link
Contributor

rnjudge commented Jun 6, 2022

Hi @vargenau -- Good catch! You may also want to file an issue with the SPDX tools repo as the document seems to validate for me even with the False value.

(ternenv) rjudge:tern$ tern --version
Tern at commit 43fd06fd0bae58b02d632be7f833613a7de06b16
   python version = 3.8.10 (default, Nov 26 2021, 20:14:08)

(ternenv) rjudge:tern$ tern report -f spdxtagvalue -i mariadb:latest -o mariadb.spdx

(ternenv) rjudge:tern$ cat mariadb.spdx | grep False
FilesAnalyzed: False

(ternenv) rjudge:tern$ java -jar /home/rjudge/spdx-tools-2.2.7-jar-with-dependencies.jar Verify mariadb.spdx
This SPDX Document is valid.

@vargenau
Copy link
Contributor Author

vargenau commented Jun 8, 2022

Hi @rnjudge

Here it is: spdx/spdx-online-tools#374

@vargenau
Copy link
Contributor Author

vargenau commented Jun 8, 2022

In fact, it is https://github.com/spdx/spdx-online-tools/issues/372

Since it was moved to spdx/spdx-java-tagvalue-store#22, I did not find it the list and thought I had not created it.

rnjudge pushed a commit that referenced this issue Jun 9, 2022
Use correct case for 'false'.

Resolves: #1170

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants