Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ Add staking hooks to track issuance change of luna #214

Closed
wants to merge 1 commit into from

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jul 17, 2019

** Summary of changes **

This PR change issuance tracker to refer staking pool's notBondedTokens and to update bonded denom(LUNA)'s issuance after staking hooks.

Related Issue #209

** Report of required housekeeping **

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

======

** (FOR ADMIN) Before merging **

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Jul 17, 2019
@yun-yeo yun-yeo added the bug Something isn't working label Jul 17, 2019
@yun-yeo yun-yeo requested review from dokwon and hanjukim July 17, 2019 03:34
@yun-yeo yun-yeo changed the title Add staking hooks to track issuance change of luna Bugfix/add staking hooks to track issuance change of luna Jul 17, 2019
@yun-yeo yun-yeo changed the title Bugfix/add staking hooks to track issuance change of luna Bugfix/ Add staking hooks to track issuance change of luna Jul 17, 2019
@dokwon
Copy link
Contributor

dokwon commented Jul 22, 2019

@YunSuk-Yeo just realized that if we merge in v0.36 of the SDK, it will have the supply module that tracks the supply of currencies. We won't need to use staking hooks to track the issuance of luna.

May require major refactoring.

@yun-yeo
Copy link
Contributor Author

yun-yeo commented Aug 30, 2019

will be coverd by columbus-3 branch

@yun-yeo yun-yeo closed this Aug 30, 2019
@yun-yeo yun-yeo deleted the bugfix/issuance-tracking-hook branch August 30, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants