Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adopt gov module #234

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Feature/adopt gov module #234

merged 1 commit into from
Sep 24, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 17, 2019

Summary of changes

As proposed #216 & #204 , add governance module. distribution module already contains community-pool-spend proposal suitable for budget so budget module is removed. There are two custom governance proposals from treasury module; tax-rate-update&reward-weight-update proposals.

New EndPoints

(GET)/gov/proposals
(GET)/gov/proposals/{proposalId}
(GET)/gov/proposals/{proposalId}/proposer
(GET)/gov/proposals/{proposalId}/deposits
(GET)/gov/proposals/{proposalId}/deposits/{depositor}
(GET/POST)/gov/proposals/{proposalId}/votes
(GET)/gov/proposals/{proposalId}/votes/{voter}
(GET)/gov/proposals/{proposalId}/tally
(GET)/gov/parameters/deposit
(GET)/gov/parameters/tallying
(GET)/gov/parameters/voting
(POST)/gov/proposals/tax_rate_update
((POST)/gov/proposals/reward_weight_update
(POST)/gov/proposals/param_change
(POST)/gov/proposals/community_pool_spend

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added enhancement New feature or request must Mustfix for target release. labels Sep 18, 2019
@yun-yeo yun-yeo requested a review from dokwon September 18, 2019 03:31
@yun-yeo yun-yeo changed the title Feature/adopt gov module(wip) Feature/adopt gov module Sep 18, 2019
@yun-yeo yun-yeo self-assigned this Sep 18, 2019
x/treasury/client/cli/tx.go Outdated Show resolved Hide resolved
x/treasury/client/cli/tx.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
x/treasury/internal/types/proposal.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #234 into develop will increase coverage by 0.26%.
The diff coverage is 73.33%.

@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
+ Coverage    67.57%   67.83%   +0.26%     
===========================================
  Files           68       70       +2     
  Lines         2942     3050     +108     
===========================================
+ Hits          1988     2069      +81     
- Misses         846      872      +26     
- Partials       108      109       +1

Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokwon dokwon merged commit c276f99 into develop Sep 24, 2019
@dokwon dokwon deleted the feature/adopt-gov-module branch September 24, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request must Mustfix for target release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants