-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adopt gov module #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
added
enhancement
New feature or request
must
Mustfix for target release.
labels
Sep 18, 2019
dokwon
suggested changes
Sep 23, 2019
yun-yeo
force-pushed
the
feature/adopt-gov-module
branch
from
September 23, 2019 03:25
7f29afd
to
9b88155
Compare
Codecov Report
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
+ Coverage 67.57% 67.83% +0.26%
===========================================
Files 68 70 +2
Lines 2942 3050 +108
===========================================
+ Hits 1988 2069 +81
- Misses 846 872 +26
- Partials 108 109 +1 |
…pdate gov proposal
yun-yeo
force-pushed
the
feature/adopt-gov-module
branch
from
September 23, 2019 04:54
9b88155
to
db32666
Compare
dokwon
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As proposed #216 & #204 , add governance module.
distribution
module already containscommunity-pool-spend
proposal suitable forbudget
so budget module is removed. There are two custom governance proposals fromtreasury
module;tax-rate-update
&reward-weight-update
proposals.New EndPoints
(GET)/gov/proposals
(GET)/gov/proposals/{proposalId}
(GET)/gov/proposals/{proposalId}/proposer
(GET)/gov/proposals/{proposalId}/deposits
(GET)/gov/proposals/{proposalId}/deposits/{depositor}
(GET/POST)/gov/proposals/{proposalId}/votes
(GET)/gov/proposals/{proposalId}/votes/{voter}
(GET)/gov/proposals/{proposalId}/tally
(GET)/gov/parameters/deposit
(GET)/gov/parameters/tallying
(GET)/gov/parameters/voting
(POST)/gov/proposals/tax_rate_update
((POST)/gov/proposals/reward_weight_update
(POST)/gov/proposals/param_change
(POST)/gov/proposals/community_pool_spend
Report of required housekeeping
(FOR ADMIN) Before merging