Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint version to v1.22.2 #312

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jan 9, 2020

Summary of changes

  • Update golangci-lint version

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the devtools devtool related update label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #312 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #312   +/-   ##
========================================
  Coverage    72.84%   72.84%           
========================================
  Files           73       73           
  Lines         3086     3086           
========================================
  Hits          2248     2248           
  Misses         731      731           
  Partials       107      107

@yun-yeo yun-yeo self-assigned this Jan 9, 2020
@yun-yeo yun-yeo requested a review from hanjukim January 13, 2020 06:52
@yun-yeo yun-yeo merged commit bd38484 into develop Jan 14, 2020
@yun-yeo yun-yeo deleted the feature/golangci-lint-script-update branch January 14, 2020 07:55
@yun-yeo yun-yeo mentioned this pull request Jan 14, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools devtool related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants