Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Convert Custom JSON Marshaling Codec to Amino Codec #377

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jul 27, 2020

Summary of changes

follow: cosmos/cosmos-sdk#6842, cosmos/cosmos-sdk#6861

Lets merge this with SDK v0.39.1

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Jul 27, 2020
@yun-yeo yun-yeo added the bug Something isn't working label Jul 27, 2020
@yun-yeo yun-yeo requested a review from hanjukim July 27, 2020 08:04
@yun-yeo yun-yeo added the WIP work in progress label Jul 27, 2020
@yun-yeo yun-yeo changed the title Remove Custom JSON Marshaling for Vesting Accounts [Bugfix] Remove Custom JSON Marshaling for Vesting Accounts Jul 29, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #377 into develop will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #377   +/-   ##
========================================
  Coverage    65.18%   65.19%           
========================================
  Files          116      116           
  Lines         5736     5726   -10     
========================================
- Hits          3739     3733    -6     
+ Misses        1777     1775    -2     
+ Partials       220      218    -2     
Impacted Files Coverage Δ
x/auth/vesting/types/vesting_account.go 89.43% <88.88%> (+2.21%) ⬆️

@yun-yeo yun-yeo changed the title [Bugfix] Remove Custom JSON Marshaling for Vesting Accounts [Bugfix] Convert Custom JSON Marshaling Codec to Amino Codec Aug 4, 2020
@yun-yeo yun-yeo merged commit b99a7cf into develop Aug 4, 2020
@yun-yeo yun-yeo deleted the bugfix/remove-custom-json branch August 4, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants