Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CosmWasm cache update #426

Merged
merged 3 commits into from
Nov 11, 2020
Merged

[Feature] CosmWasm cache update #426

merged 3 commits into from
Nov 11, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Nov 9, 2020

Summary of changes

The problem is described here CosmWasm/cosmwasm#603.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from hanjukim November 9, 2020 08:30
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #426 (7257f0f) into develop (f2b6cd6) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #426      +/-   ##
===========================================
- Coverage    67.56%   67.51%   -0.06%     
===========================================
  Files          117      117              
  Lines         5053     5051       -2     
===========================================
- Hits          3414     3410       -4     
- Misses        1426     1427       +1     
- Partials       213      214       +1     
Impacted Files Coverage Δ
x/oracle/tally.go 88.37% <0.00%> (-4.66%) ⬇️
x/auth/vesting/types/schedule.go 63.63% <0.00%> (-1.28%) ⬇️

@yun-yeo yun-yeo self-assigned this Nov 9, 2020
@yun-yeo yun-yeo added the wasm Wasm contract related update label Nov 9, 2020
@hanjukim
Copy link
Contributor

Test passed with both columbus-4 and tequila

@hanjukim hanjukim merged commit 97a1967 into develop Nov 11, 2020
@hanjukim hanjukim deleted the feature/wasm-cache branch November 11, 2020 10:32
@yun-yeo yun-yeo mentioned this pull request Nov 23, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasm Wasm contract related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants