-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump cosmos-sdk to v0.44.0 #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 44.88% 44.88%
=======================================
Files 118 118
Lines 6829 6829
=======================================
Hits 3065 3065
Misses 3527 3527
Partials 237 237
|
11 tasks
…t leagcy tx to proto tx internally and broadcast it
The /txs endpoint was removed from Cosmos SDK because of a security vulnerability, have you check to not be affected? |
Yea we applied some fix to prevent breaking backward compatibility. |
reuvenpo
referenced
this pull request
in scrtlabs/cosmos-sdk
Oct 7, 2021
Cashmaney
referenced
this pull request
in scrtlabs/cosmos-sdk
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Client Breaking Changes
Cosmos SDK stopped supporting legacy amino style transaction, which means
/txs
endpoint will not be working anymore. However there are so many entities who are still using legacy style transaction building method, so we thinkit is necessary to give enough time to prepare for this kind of updates.
To avoid sudden big changes, we introduce our custom
/txs
endpoint.Our custom
/txs
endpoint receive more optional inputs as followReport of required housekeeping
(FOR ADMIN) Before merging