Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] emit missing wasm tax events #566

Merged
merged 2 commits into from
Sep 27, 2021
Merged

[Bugfix] emit missing wasm tax events #566

merged 2 commits into from
Sep 27, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 27, 2021

Summary of changes

close #565

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #566 (abaa9de) into main (4f37d36) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   44.54%   44.58%   +0.04%     
==========================================
  Files         120      120              
  Lines        6924     6926       +2     
==========================================
+ Hits         3084     3088       +4     
+ Misses       3601     3600       -1     
+ Partials      239      238       -1     
Impacted Files Coverage Δ
x/wasm/keeper/connector.go 79.76% <100.00%> (+0.49%) ⬆️
x/oracle/tally.go 91.89% <0.00%> (+5.40%) ⬆️

@yun-yeo yun-yeo merged commit 9a78c52 into main Sep 27, 2021
@yun-yeo yun-yeo deleted the bugfix/wasm-tax-event branch September 27, 2021 11:53
octalmage pushed a commit to octalmage/core that referenced this pull request Oct 21, 2021
* implement /txs/encode endpoint for backward compatibility

* emit wasm tax event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] wasm tax events are missing
2 participants