Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add ibc ante to prevent duplicate packet from relayer #583

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 19, 2021

Summary of changes

Append IBC ante decorator to reject transactions that only contain redundant packet messages. This will prevent relayers from wasting fees by submitting messages for packets that have already been processed by previous relayer(s). The Antedecorator is only applied on CheckTx and RecheckTx and is therefore optional for each node.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from hanjukim October 19, 2021 05:35
@yun-yeo yun-yeo self-assigned this Oct 19, 2021
@yun-yeo yun-yeo added the enhancement New feature or request label Oct 19, 2021
@yun-yeo yun-yeo changed the title add ibc ante to prevent duplicate packet from relayer [Feature] add ibc ante to prevent duplicate packet from relayer Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #583 (a4c4896) into main (1581f2f) will increase coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   44.75%   44.75%           
=======================================
  Files         121      121           
  Lines        6998     7000    +2     
=======================================
+ Hits         3132     3133    +1     
- Misses       3620     3621    +1     
  Partials      246      246           
Impacted Files Coverage Δ
app/app.go 0.67% <0.00%> (-0.01%) ⬇️
custom/auth/ante/ante.go 60.00% <100.00%> (+1.37%) ⬆️

@yun-yeo yun-yeo merged commit 71650f7 into main Oct 21, 2021
@yun-yeo yun-yeo deleted the feature/ibc-ante branch October 21, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants