Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] fix to use single wasmvm during recursive external query #588

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 22, 2021

Summary of changes

close #587

Also previously, only single wasmvm was used because wasm keeper did not maintain reference of ReadVMPool.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Oct 22, 2021
@yun-yeo yun-yeo added bug Something isn't working wasm Wasm contract related update labels Oct 22, 2021
@yun-yeo yun-yeo requested a review from hanjukim October 22, 2021 01:59
@yun-yeo yun-yeo changed the title [Bugfix] fix to use single wasmvm during recursive query [Bugfix] fix to use single wasmvm during recursive external query Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #588 (dc8e571) into main (8804d48) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   44.75%   44.78%   +0.02%     
==========================================
  Files         122      122              
  Lines        7013     7016       +3     
==========================================
+ Hits         3139     3142       +3     
  Misses       3628     3628              
  Partials      246      246              
Impacted Files Coverage Δ
x/wasm/types/keys.go 0.00% <ø> (ø)
x/wasm/keeper/contract.go 79.00% <100.00%> (+0.16%) ⬆️
x/wasm/keeper/keeper.go 81.81% <100.00%> (ø)
x/wasm/keeper/legacy_querier.go 35.22% <100.00%> (+0.74%) ⬆️
x/wasm/keeper/pool.go 83.33% <100.00%> (ø)
x/wasm/keeper/querier.go 35.38% <100.00%> (ø)

@yun-yeo yun-yeo added the client rest / cli code improvements label Oct 22, 2021
@yun-yeo yun-yeo requested a review from csanti October 22, 2021 03:57
@yun-yeo yun-yeo merged commit 6235f92 into main Oct 22, 2021
@yun-yeo yun-yeo deleted the bugfix/external-wasm-querier branch October 22, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client rest / cli code improvements wasm Wasm contract related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] external wasm querier end up as single wasmvm
2 participants