Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] export for zero height #621

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Dec 6, 2021

Summary of changes

close #615

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from Vritra4 December 6, 2021 01:57
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #621 (cdffb46) into main (c080a55) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   44.74%   44.74%           
=======================================
  Files         120      120           
  Lines        6969     6968    -1     
=======================================
  Hits         3118     3118           
+ Misses       3613     3612    -1     
  Partials      238      238           
Impacted Files Coverage Δ
app/export.go 0.00% <0.00%> (ø)

@yun-yeo yun-yeo merged commit 54f15c0 into main Dec 6, 2021
@yun-yeo yun-yeo deleted the bugfix/fix-export-for-zero-height branch December 6, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] terrad export panic
2 participants