Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getBlock return 404 when no block exist #3

Merged
merged 2 commits into from
May 30, 2022
Merged

fix: getBlock return 404 when no block exist #3

merged 2 commits into from
May 30, 2022

Conversation

jeffwoooo
Copy link
Contributor

No description provided.

@jeffwoooo jeffwoooo requested a review from hanjukim May 30, 2022 02:08
hanjukim
hanjukim reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@hanjukim hanjukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just throw APIError in service/transaction/getTxList

@jeffwoooo jeffwoooo merged commit dcb19b1 into main May 30, 2022
@jeffwoooo jeffwoooo deleted the block-not-found-response branch May 30, 2022 02:15
emidev98 pushed a commit that referenced this pull request Mar 27, 2023
Merge pull request #3 from classic-terra/container-cleanup-and-optimi…
5b7e040 
…zation

added docker-compose readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanjukim hanjukim hanjukim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwoooo @hanjukim