Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GRPC supports query's height param #13

Merged
merged 1 commit into from
Dec 20, 2021
Merged

feat: GRPC supports query's height param #13

merged 1 commit into from
Dec 20, 2021

Conversation

jeffwoooo
Copy link

  • GRPC gateway parses query's height parameter from the x-cosmos-block-height rather than URL.
  • setting height into request header before parsing would be an workaround.

@jeffwoooo jeffwoooo requested a review from kjessec December 17, 2021 07:12
kjessec
kjessec approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@kjessec kjessec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjessec kjessec merged commit 86f44af into main Dec 20, 2021
@jeffwoooo jeffwoooo deleted the feat/grpc-query-height branch December 21, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjessec kjessec kjessec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwoooo @kjessec