Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override slack username #54

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

etienne-napoleone
Copy link
Contributor

@etienne-napoleone etienne-napoleone commented Sep 29, 2021

Use the webhook integration username instead of overriding it.
This allows operators to make a difference between different running price servers (ex: mainnet/testnet) alerts by using one webhook integration per price-server

Use the default webhook integration username. this allows operators to make a difference between different running price servers (ex: mainnet/testnet)
@hanjukim hanjukim self-requested a review September 29, 2021 21:31
@hanjukim hanjukim merged commit 53beabb into main Sep 29, 2021
@etienne-napoleone etienne-napoleone deleted the feature/slack-default-user branch October 1, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants